Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with new dependencies #127

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

baryluk
Copy link
Contributor

@baryluk baryluk commented Nov 17, 2023

libfreetype6-dev is a deprecated (long time ago) transitional package. Use proper one instead.

Add appstream compose header files.

Add yarnpkg, as otherwise default build instructions will not work.

libfreetype6-dev is a deprecated (long time ago) transitional package. Use proper one instead.

Add appstream compose header files.

Add yarnpkg, as otherwise default build instructions will not work.
@baryluk
Copy link
Contributor Author

baryluk commented Nov 17, 2023

Honestly, I do not know where freetype is even used in the source code. I could not find any use of it.

And if I remove all freetype related header files from my system it still builds just fine. (Also in Debian I see they do not list freetype as a dependency - https://salsa.debian.org/pkgutopia-team/appstream-generator/-/blob/debian/master/debian/control )

@ximion
Copy link
Owner

ximion commented Nov 17, 2023

Honestly, I do not know where freetype is even used in the source code. I could not find any use of it.

I think you can drop it, the code that used it has been spun out into an external library and the generator itself no longer needs it :-)

@baryluk
Copy link
Contributor Author

baryluk commented Nov 17, 2023

Lets merge this as is. Can clean more in separate PR.

I think it is now more than just freetype that is not required. Does it depended on cairo and pango directly anymore?

@baryluk
Copy link
Contributor Author

baryluk commented Nov 17, 2023

You can ignore Debian testing build failure. This is due to https://tracker.debian.org/pkg/glib-d still not migrating from unstable to testing. (Will do in few days - appstream-generator does build fine with one from unstable, I tested it few minutes ago).

@baryluk
Copy link
Contributor Author

baryluk commented Nov 17, 2023

Oh. @ximion I did not realize that is you Matthias. :)

@ximion
Copy link
Owner

ximion commented Nov 17, 2023

Does it depended on cairo and pango directly anymore?

No, documentation is quite outdated since a bunch of this code was rewritten in C (pretty my all the nasty stuff is in compose now).

Oh. @ximion I did not realize that is you Matthias. :)

Way too much stuff in few hands ;-)

There's no reason not to merge this change, but to really fix this we'd need to update the whole dependency list. The one at Debian should be accurate.

@ximion ximion merged commit 84c671e into ximion:master Nov 17, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants